[PATCH] D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 08:10:25 PST 2019


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9614a7c93915 (authored by jhenderson).

Changed prior to commit:
  https://reviews.llvm.org/D71202?vs=232828&id=233110#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71202/new/

https://reviews.llvm.org/D71202

Files:
  llvm/test/tools/llvm-cxxfilt/simple.test


Index: llvm/test/tools/llvm-cxxfilt/simple.test
===================================================================
--- llvm/test/tools/llvm-cxxfilt/simple.test
+++ llvm/test/tools/llvm-cxxfilt/simple.test
@@ -1,7 +1,7 @@
 ## Show that llvm-cxxfilt can handle basic demangling for command-line inputs,
 ## including when they are part of a string. Note that this test uses "-n"
-## because on darwin, the default for --strip-underscore is true, but false
-## elsewhere.
+## (alias for --no-strip-underscore) because on darwin, the default for
+## --strip-underscore is true, but false elsewhere.
 
 RUN: llvm-cxxfilt -n _Z1fi abc | FileCheck %s
 RUN: echo "Mangled _Z1fi and _Z3foov in string." | llvm-cxxfilt -n \


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71202.233110.patch
Type: text/x-patch
Size: 715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191210/c13149cc/attachment.bin>


More information about the llvm-commits mailing list