[PATCH] D71209: InstCombine: Don't rewrite phi-of-bitcast when the phi has other users

[Connor Abbott via Phabricator via llvm-commits]

cwabbott marked an inline comment as done.
cwabbott added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/pr44242.ll:1
+; RUN: opt -S -instcombine < %s | FileCheck %s
+
----------------
nikic wrote:
> cwabbott wrote:
> > lebedev.ri wrote:
> > > Please autogenerate and precommit tests.
> > Sorry, but what exactly do you mean?
> You can use `utils/update_test_checks.py` to generate the expected output. Then you should first commit just the test (with generated output without your patch). The patch will then only show the IR diff in the test, making is clearer what actually changed.
Hopefully I did that right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71209/new/

https://reviews.llvm.org/D71209