[PATCH] D71255: llc: Change behavior of -mattr with existing attribute

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: echristo, ahatanak.
Herald added subscribers: jfb, dexonsmith, aheejin, jgravelle-google, sbc100, wdng, dschuff.
Herald added a project: LLVM.
arsenm added a parent revision: D71253: llc/MIR: Fix setFunctionAttributes for MIR functions.
arsenm added a parent revision: D71254: llc: Change behavior of -mcpu with existing attribute.

Append this to the existing target-features attribute on the function.

      

Some flags ignore existing attributes, and some overwrite them. Move
towards consistently respecting existing attributes if present. Since
target features act as a state machine on their own, append to the
function attribute. The backend default added feature list, function
attributes, and -mattr will all be appended together, and the later
features can individually toggle the earlier settings.


https://reviews.llvm.org/D71255

Files:
  llvm/include/llvm/CodeGen/CommandFlags.inc
  llvm/test/CodeGen/WebAssembly/target-features.ll
  llvm/test/Other/opt-override-mcpu-mattr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71255.233053.patch
Type: text/x-patch
Size: 4386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191210/dc7aa0ac/attachment.bin>