[PATCH] D71218: [FPEnv] Remove rounding mode argument for constrained minnum/maxnum

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 02:59:45 PST 2019


uweigand added a comment.

In D71218#1775695 <https://reviews.llvm.org/D71218#1775695>, @craig.topper wrote:

> I've also been wondering if we should drop rounding from ceil, floor, trunc, and round. Looks like lround/llround don't have rounding.


Yes, I think it is probably best to only have the rounding mode argument for those functions that actually depend on the current rounding mode.  I can remove it from those four as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71218/new/

https://reviews.llvm.org/D71218





More information about the llvm-commits mailing list