[PATCH] D71118: [llvm-readelf/llvm-readobj] - Improved the error reporting in a few method related to versioning.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 01:56:14 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor comment.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test:266
 
-## Check we error out when trying to print version symbols, but SHT_GNU_verdef is invalid due to any reason.
+## Check we report when trying to print version symbols, but SHT_GNU_verdef
+## is invalid due to any reason.
----------------
Actually, on re-read, I realise that this should be "Check we report a warning when..."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71118/new/

https://reviews.llvm.org/D71118





More information about the llvm-commits mailing list