[PATCH] D70582: [FPEnv][X86] Constrained FCmp intrinsics enabling on X86

Tue Dec 10 01:29:02 PST 2019

pengfei added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3560
+      if (IsStrict) {
+        DAG.ReplaceAllUsesOfValueWith(SDValue(Node,1), Chain);
+        ReplaceNodeWithValue(SDValue(Node, 0), Tmp1);
----------------
pengfei wrote:
> craig.topper wrote:
> > pengfei wrote:
> > > craig.topper wrote:
> > > > Can we add to the Results vector here instead of doing manual replacement?
> > > I think so. Thanks!
> > Don’t use merge values, just push both results to the vector
> Done. Does it matter for the push order?
Oh, it does matter.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70582/new/

https://reviews.llvm.org/D70582