[PATCH] D71191: [TableGen] Add bang-operators !getop and !setop.

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 23:48:46 PST 2019


nhaehnle added a comment.

This looks fine, but have you thought through !setop discarding the name on the operand? The only use of this feature seems to be naming DAG pattern nodes, a feature that seems to have been around forever but I haven't seen used in the code I've touched...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71191/new/

https://reviews.llvm.org/D71191





More information about the llvm-commits mailing list