[PATCH] D70910: [compiler-rt] Add a critical section when flushing gcov counters

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 20:57:25 PST 2019


jfb added a comment.

When you say "when the process is forked in different threads" you mean threads, not fork, right? Because this won't fix any issues you're seeing with fork.

It's also unclear that this fixes the issue correctly. `flush_fn_head` is accessible from other functions, also unprotected. Can the other functions be invoked while this one is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70910/new/

https://reviews.llvm.org/D70910





More information about the llvm-commits mailing list