[PATCH] D71238: Align non-fused branches within 32-Byte boundary (basic case)

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 20:57:23 PST 2019


skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:394-395
+
+  // Insert BranchPadding before the instruction need to be aligned.
+  auto *F = new MCBoundaryAlignFragment(AlignBoundarySize);
+  OS.insert(F);
----------------
There is a deficiency here. For example, there may be a `MCAlignFragment` fragment between the `MCBoundaryAlignFragment` and the branch to be aligned, which will result an infinite loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71238/new/

https://reviews.llvm.org/D71238





More information about the llvm-commits mailing list