[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use _record suffix instead of o

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 20:12:30 PST 2019


jsji added a comment.

In D70758#1776123 <https://reviews.llvm.org/D70758#1776123>, @hfinkel wrote:

> So the common subset is `_rec`, right?


Yes, you are right! I will update the patch to use `_rec`.

In D70758#1776504 <https://reviews.llvm.org/D70758#1776504>, @steven.zhang wrote:

> When my first time see the suffix "o" in the opcode, it is really hard for me to know that it is record form...(o stands for .)


Thanks for double confirming the problem.

> I will vote for abandon if we want to change it to _rec or _record.

I think we shouldn't abandon just due to longer name. 
As I mentioned above, yes,  renaming may be somehow *ugly* to someone,
but I see the benefits outweigh tidy/compact code. (especially for newcomers).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758





More information about the llvm-commits mailing list