[PATCH] D71147: [ConstantFold][SVE] Fix constant folding for shufflevector.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 14:54:09 PST 2019


efriedma marked an inline comment as done.
efriedma added a comment.

> I haven't looked at scalable vectors very much though, so I'm not sure if there are still problems for any other opcodes.

There are; Huihui is going to look into this.  This particular case happened to be blocking some other work I'm doing.



================
Comment at: llvm/test/Analysis/ConstantFolding/shufflevector.ll:4
+
+define <vscale x 4 x i32> @shufflevector_scalable_constant() {
+; CHECK-LABEL: @shufflevector_scalable_constant(
----------------
spatel wrote:
> Can reduce this to a single shuffle and still get the same crash?
> 
> ```
> define <vscale x 4 x i32> @shufflevector_scalable_constant() {
>   %r = shufflevector <vscale x 4 x i32> undef, <vscale x 4 x i32> undef, <vscale x 4 x i32> zeroinitializer
>   ret <vscale x 4 x i32> %r
> }
> 
> ```
We'll probably fold that to undef at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71147/new/

https://reviews.llvm.org/D71147





More information about the llvm-commits mailing list