[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 14:35:37 PST 2019


dexonsmith added a comment.

In D71219#1776085 <https://reviews.llvm.org/D71219#1776085>, @rjmccall wrote:

> Yeah, the discussion Jin and I had privately was that we should split the Swift ABI version out of the ObjC GC global metadata and update the backend so that it assembles the image info appropriately from different places.  I don't know what happened to that.
>
> That will probably require an IR updater, but that shouldn't be a problem.


Something like that SGTM.  @jinlin, the logic for auto upgrading bitcode is in lib/IR/AutoUpgrade.cpp.  I'm not sure whether there are module flags that get updated right now; let me or @steven_wu know if need a pointer there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71219/new/

https://reviews.llvm.org/D71219





More information about the llvm-commits mailing list