[PATCH] D71205: [NFC] Add a SDValue overload for SelectionDAG::getMemBasePlusOffset()

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 14:10:07 PST 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5734
   EVT VT = Base.getValueType();
   return getNode(ISD::ADD, DL, VT, Base, getConstant(Offset, DL, VT));
 }
----------------
Should we rewrite this in terms of the new function? Perhaps by moving to the header file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71205/new/

https://reviews.llvm.org/D71205





More information about the llvm-commits mailing list