[PATCH] D71177: [ValueTracking] Use the assumption that if the pointer was loaded/stored, then it is nonnull.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 12:44:33 PST 2019


lebedev.ri added a comment.

In D71177#1775827 <https://reviews.llvm.org/D71177#1775827>, @danlark wrote:

> In D71177#1775789 <https://reviews.llvm.org/D71177#1775789>, @lebedev.ri wrote:
>
> > In D71177#1775688 <https://reviews.llvm.org/D71177#1775688>, @jdoerfert wrote:
> >
> > > > Also, I don't have commit rights.
> > >
> > > @lebedev.ri From my perspective this is fine. Feel free to accept and commit this.
> >
> >
> > I also currently don't have any further counter-examples here.
> >
> > @danlark please specify `who <e at ma.il>` to be used for the change.
>
>
> I don't get what you mean, in the commit message it is said to state my name and that's all. https://llvm.org/docs/DeveloperPolicy.html#commit-messages


Now that the repo is using git, it is possible to not just mention the original patch's author textually,
but actually specify the actual git commit author, #commit-messages isn't up-to-date about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71177/new/

https://reviews.llvm.org/D71177





More information about the llvm-commits mailing list