[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:6
+
+# python 2.7 backwards compatibility
+try:
----------------
What's the status of Python 3 compatibility of lit? Can we skip the tests if the legacy Python 2 is used?


================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:48
+if py3_exe:
+    config.substitutions.append(('%python3', '\'' + py3_exe + '\''))
+    config.available_features.add('python3')
----------------
`'\''` -> `"'"`

Why isn't this `shell_quote`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660