[PATCH] D71203: [llvm-readobj][test] - Move platform specific test cases and their inputs to separate folders.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

This change makes me very happy, LGTM.

I think an obvious follow-up would be to split the multi-format tests up into separate tests.

I wonder how many holes in test coverage for different formats this shows up? That could be an interesting follow-on piece of work (not asking you to do it, just an observation).



================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:3
 # RUN: yaml2obj --docnum=1 -o %t.hex \
-# RUN:          %S/../llvm-readobj/Inputs/elf-dynamic-tags-machine-specific.yaml
+# RUN:          %S/../llvm-readobj/ELF/Inputs/elf-dynamic-tags-machine-specific.yaml
 # RUN: llvm-objdump -p %t.hex | FileCheck %s --check-prefix=HEXAGON
----------------
The fact that this test relies on an input in llvm-readobj seems a bit bizarre to me, frankly!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71203/new/

https://reviews.llvm.org/D71203