[PATCH] D71132: PostRA Machine Sink should count COPY defining register used by another COPY

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 06:04:13 PST 2019


alex-t added a comment.

In D71132#1774315 <https://reviews.llvm.org/D71132#1774315>, @nhaehnle wrote:

> With this change, it looks as though accumulateUsedDefed is called multiple times on some paths. That seems wrong.


Not in fact wrong - just not optimal. The accumulateUsedDefed  inside does bitwise OR for reg units.
And doing OR twice for same index does not introduce incorrect information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71132/new/

https://reviews.llvm.org/D71132





More information about the llvm-commits mailing list