[PATCH] D70781: AMDGPU: Fix handling of infinite loops in fragment shaders

[Connor Abbott via Phabricator via llvm-commits]

cwabbott added a comment.

In D70781#1774320 <https://reviews.llvm.org/D70781#1774320>, @nhaehnle wrote:

> If two exports with done bit are executed, I suspect we could enter race conditions where the export allocation is freed after the first export with done, and then another wave gets the same export memory spot and its data could be overwritten by the second, newly introduced, export with done bit. Or enter some hang condition in the hardware. Who knows.


Thanks for mentioning this. I wasn't entirely sure if what I was doing is kosher, since the public documentation on exports is a little sparse, even though it worked for the test. I've implemented clearing the done bit like you've suggested... it shouldn't hurt at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70781/new/

https://reviews.llvm.org/D70781