[PATCH] D71163: [ELF] --icf: do not fold preemptible symbols

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Generally LG.



================
Comment at: lld/ELF/Symbols.h:557
 void maybeWarnUnorderableSymbol(const Symbol *sym);
+bool computeIsPreemptible(const Symbol &s);
+
----------------
use `sym` for consistency with the definition of `maybeWarnUnorderableSymbol`?


================
Comment at: lld/test/ELF/icf-preemptible.s:19
+# NONLEAF:        removing identical section {{.*}}:(.text.g2)
+# LEAF-NEXT:      removing identical section {{.*}}:(.text.g3)
+
----------------
Not sure `LEAF` and `NONLEAF` are clear to me.
I have no suggestions about how to name them better though.
It seems a bit hard to invent good names when checks are mixed.
If they were separated you could use just "DSO" and "EXE" probably.
May be others will have any ideas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71163/new/

https://reviews.llvm.org/D71163