[PATCH] D71165: [LoopFusion] Move instructions from FC0.Latch to FC1.Latch.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I'm generally OK with this. Two comments below, otherwise assume I'm fine with it, I mean no need to wait for me.

We miss a negative test. I mean one with instruction(s) that cannot be moved.

I find it odd to add the same code twice. Please put it in helper functions.



================
Comment at: llvm/test/Transforms/LoopFusion/loop_nest.ll:36
+; CHECK-NEXT: %add.outer.fc0 = add nuw nsw i32 %.06, 1
+; CHECK-NEXT: %cmp.outer.fc0 = icmp ne i64 %inc.outer.fc0, 100
+; CHECK: br i1 %{{.*}}, label %[[LOOP1HEADER]], label %[[LOOP1EXIT:bb[0-9]*]]
----------------
Nit: It might be good to commit the renaming of the instructions and the checking for them before as a NFC commit (no need to ask for a review).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71165/new/

https://reviews.llvm.org/D71165