[PATCH] D71147: [ConstantFold][SVE] Fix constant folding for shufflevector.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

Similar to D70985 <https://reviews.llvm.org/D70985> - LGTM.

I haven't looked at scalable vectors very much though, so I'm not sure if there are still problems for any other opcodes. Eg, ConstantFoldSelectInstruction can iterate based on number of elements.



================
Comment at: llvm/test/Analysis/ConstantFolding/shufflevector.ll:4
+
+define <vscale x 4 x i32> @shufflevector_scalable_constant() {
+; CHECK-LABEL: @shufflevector_scalable_constant(
----------------
Can reduce this to a single shuffle and still get the same crash?

```
define <vscale x 4 x i32> @shufflevector_scalable_constant() {
  %r = shufflevector <vscale x 4 x i32> undef, <vscale x 4 x i32> undef, <vscale x 4 x i32> zeroinitializer
  ret <vscale x 4 x i32> %r
}

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71147/new/

https://reviews.llvm.org/D71147