[PATCH] D70897: [Matrix] Add forward shape propagation and first shape aware lowerings.

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 8 02:35:53 PST 2019


LuoYuanke added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:365
+        if (OpShape != ShapeMap.end())
+          setShapeInfo(Inst, OpShape->second);
+        continue;
----------------
It seems only store instruction is propagated with the shape information. Why? Take below pseudo code for example. Are v2 and v3 propagated with the shape information?   
```
v1 = matrix_columnwise_load(..., m, n)
v2 = max(v1, 0)
v3 = v1 / v2
store v3, ptr
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70897/new/

https://reviews.llvm.org/D70897





More information about the llvm-commits mailing list