[PATCH] D71163: [ELF] --icf: do not fold preemptible symbols

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 7 09:04:39 PST 2019


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/ICF.cpp:262
 
+    if (da->isPreemptible || db->isPreemptible)
+      return false;
----------------
I may place a comment that replicates the patch summary here

> When comparing a pair of relocations, if they refer to different symbols, and either symbol is preemptible, the containing sections should be considered different.

If you have a wording suggestion, please tell me:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71163/new/

https://reviews.llvm.org/D71163





More information about the llvm-commits mailing list