[PATCH] D52634: [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations

[Yury Delendik via Phabricator via llvm-commits]

yurydelendik marked an inline comment as done.
yurydelendik added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:651
+// Extensions for WebAssembly.
+HANDLE_DW_OP(0xed, WASM_location, 0, WASM)
 // The GNU entry value extension.
----------------
aprantl wrote:
> LLVM's list of vendor extensions is unfortunately not complete. (Pathces very welcome!) Have you checked that this enumerator is actually available? You might want to check libdwarf and the list of GNU extensions. Generally I would recommend using an enumerator that isn't close to the other GNU values, unless you also plan to add this to binutils etc.
> Have you checked that this enumerator is actually available? 

There is no codes specified for range between 0xe1 - 0xef per https://sourceware.org/elfutils/DwarfExtensions. The 0xed was chosen to be far from edges of that range. I also checked libdwarf/dwarf.h for availability.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52634/new/

https://reviews.llvm.org/D52634