[PATCH] D70597: [PHIEliminate] skip dbg instruction when LowerPHINode

[Chris Ye via Phabricator via llvm-commits]

yechunliang updated this revision to Diff 232549.
yechunliang added a comment.
Herald added subscribers: ormris, MatzeB.

description for updated revision:

  move dbg values after label for phi elimination
  
  * If there is the dbg_values between phi and label (after phi and before label),
    dbg_values will block PHI to lower after LABELs. To fix this issue, insert
    all dbg_values after Labels in the function ScheduleDAGSDNodes::EmitSchedule,
    Moving dbg_value in the first place to avoid dbg_value impact PHI lowering.
    before:
       phi
       dbg_value
       label
    after:
       LABEL
       COPY
       DBG_VALUE
  
    Fix the issue: https://bugs.llvm.org/show_bug.cgi?id=43859
  
  * Re-add some important comments for PHIElimination APIs from original deleted comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70597/new/

https://reviews.llvm.org/D70597

Files:
  llvm/lib/CodeGen/PHIElimination.cpp
  llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp
  llvm/test/CodeGen/X86/dbg-changes-codegen-phi-elimination.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70597.232549.patch
Type: text/x-patch
Size: 5141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191206/63e22009/attachment-0001.bin>