[PATCH] D67105: [TargetLowering] Fix another potential FPE in expandFP_TO_UINT

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 02:21:26 PST 2019


uweigand added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:19081
+                                   DAG.getConstantFP(0.0, DL, TheVT),
+                                   Value);
+
----------------
I think this needs to be ThreshVal instead of Value here.  Otherwise the FSUB below will always return zero in that case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67105/new/

https://reviews.llvm.org/D67105





More information about the llvm-commits mailing list