[PATCH] D70942: [LegalizeTypes] Bugfixes for big-endian targets when handling BITCASTs

[Mikael Holmén via Phabricator via llvm-commits]

uabelho marked an inline comment as done.
uabelho added a comment.

Thanks for the suggestion @spatel. Updated the testcase.



================
Comment at: llvm/test/CodeGen/ARM/legalize-bitcast.ll:1
+; RUN: llc -O0 -mtriple=armebv7 -target-abi apcs -o - %s -stop-before=finalize-isel | FileCheck %s
+
----------------
spatel wrote:
> The bug is still visible if you let this RUN all the way to asm output, right?
> If so, I think that would be easier to read, especially if we can auto-generate the CHECK lines using "utils/update_llc_test_checks.py".
> Either way, I think it's better to pre-commit this test to trunk showing the wrong output. That way, this patch will show the diff that creates the correct code. (And if for some reason this patch needs to be reverted, it will be clear that we have reverted to code that creates a miscompile.)
I think so. At least we get diffs in the ASM output without/with the fixes applied.
I'm really not very good at reading ARM assembler though so it's not at all obvious to me what the resulting code really do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70942/new/

https://reviews.llvm.org/D70942