[PATCH] D70750: [AutoFDO] Inline replay for cold/small callees from sample profile loader

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

> Did performance test and I saw 0.4% improvement in an internal benchmark. That is a good improvement, thanks for the change!

Thanks for doing the measurement. I'm really glad that this change and other recent ones in this area helped your workload too. These are like "prototype" for the stuff we talked about a while ago. These numbers are important signals so we know what we're trying to do is at least a step in the right direction.



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:965
       }
-      if (Hot) {
-        CIS.insert(CIS.begin(), Candidates.begin(), Candidates.end());
+      if (Hot || ProfileReInlineAll) {
+        CIS.insert(CIS.begin(), AllCandidates.begin(), AllCandidates.end());
----------------
wmi wrote:
> Can we inline all by setting sample-profile-cold-inline-threshold to a very large number so ProfileReInlineAll is not needed?
good suggestion. changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70750/new/

https://reviews.llvm.org/D70750