[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:551
 namespace {
+struct PrintedExpr {
+  enum ExprKind {
----------------
jhenderson wrote:
> aprantl wrote:
> > doxygen comments explaining the purpose of this?
> This and the other places you've suggested this are anonymous namespace/static local functions in a .cpp file. I don't think it needs doxygen style comments. Also, doxygen files aren't generated for items in the tools directory.
My intent is to have a short comment here that explains to a future reader of the code what this class is used for. Using doxygen syntax `///` allows IDEs to format them more nicely and show them in code outlines / indexes etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720