[PATCH] D71032: [AIX] Make sure to use QualNames for external global objects

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 09:05:06 PST 2019


jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.

LGTM with minor nit.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll:31
 
+; We initialize a csect when we first reference an external global, so make sure we don't run into problems when we see it again.
+define void @bar2() {
----------------
Suggestion for comment:
Reference external globals again to make sure setting up csect for external global is properly guarded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71032/new/

https://reviews.llvm.org/D71032





More information about the llvm-commits mailing list