[PATCH] D70930: [llvm-objcopy][WebAssembly] Initial support for wasm in llvm-objcopy

Thu Dec 5 08:46:28 PST 2019

dschuff added a comment.

I believe I've addressed all the feedback now.

================
Comment at: llvm/tools/llvm-objcopy/wasm/Object.h:1
+//===- Object.h -------------------------------------------------*- C++ -*-===//
+//
----------------
alexshap wrote:
> I'd prefer to follow the structure which we use for other formats (MachO, COFF, ELF), i.e. put the description of the model into Object.h/Object.cpp (the class Object etc), and put the classes Reader and Writer into separate files, even if they are small at the moment, they might grow in the future, it makes things a little bit easier to read. 
> 
I don't really mind doing this, but I will note that ELF also has its Readers and Writers in Object.h

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70930/new/

https://reviews.llvm.org/D70930