[PATCH] D71032: [AIX] Make sure to use QualNames for external global objects

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 07:33:10 PST 2019


jasonliu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1897
+      XSym->setContainingCsect(Csect);
+      return Csect->getQualNameSymbol();
+    }
----------------
nit: This return statement is like a short cut, maybe we could remove it to make this if block simpler?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71032/new/

https://reviews.llvm.org/D71032





More information about the llvm-commits mailing list