[PATCH] D71024: [DebugInfo] Handle call site values for instructions before call bundle

[David Stenberg via Phabricator via llvm-commits]

dstenb marked 2 inline comments as done.
dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:621
+    // Skip bundle headers.
+    if (I->isBundle())
+      continue;
----------------
aprantl wrote:
> is there a higher-level iterator that does this skipping automatically?
AFAICT there is no such iterator.


================
Comment at: llvm/test/DebugInfo/MIR/Hexagon/dbgcall-site-instr-before-bundled-call.mir:35
+    %0 = load i32, i32* @ga, align 4, !dbg !26
+    call void @llvm.dbg.value(metadata i32 %0, metadata !23, metadata !DIExpression()), !dbg !27
+    %1 = load i32, i32* @gb, align 4, !dbg !28
----------------
vsk wrote:
> Are the dbg.value/DBG_VALUE's necessary?
No, I'll clean them up!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71024/new/

https://reviews.llvm.org/D71024