[PATCH] D70978: Revert "AMDGPU: Try to commute sub of boolean ext"

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 00:43:51 PST 2019


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll:141
-; GFX9: v_add_u32_e32 {{.*}}, 0x64, [[ADDC]]
-define amdgpu_kernel void @sub_sube_commuted(i32 addrspace(1)* nocapture %arg, i32 %a) {
-bb:
----------------
I think leaving the broken tests with the new emitted code would be more helpful than just deleting them


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70978/new/

https://reviews.llvm.org/D70978





More information about the llvm-commits mailing list