[PATCH] D70223: [DAGCombine] Split vector load-update-store into single element stores

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf planned changes to this revision.
qiucf added a comment.

Thanks for comments and explanation from everyone. I think there're two key issues to clarify and solve about this revision:

1. Implementation code is too complicated but focused on a specialized case. It tries to search in tree but what we actually can do is not so much. So I'm going to simplify the logic, and cut some extremely rare cases if necessary.
2. How many elements are suitable for optimization indeed? I didn't get obvious better results in benchmarks. Although we can use target information on `DAGCombiner`, it's more suitable placed at `InstCombine`, in concept, I think. Since `TargetTransformInfo` may not always suitable here, should we start from only do this for 1-element case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70223/new/

https://reviews.llvm.org/D70223