[PATCH] D70691: Optimization record for bytecode input missing- PR44000

Erich Keane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 4 08:17:47 PST 2019


erichkeane added a comment.

Otherwise I think I'm OK.  @thegameg ?



================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:85
 
+  static void reportError(Error E, DiagnosticsEngine &Diags,
+                          const CodeGenOptions CodeGenOpts) {
----------------
not sure we can call this "reportError", as its too generic.  how about reportOptRecordError?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70691/new/

https://reviews.llvm.org/D70691





More information about the llvm-commits mailing list