[PATCH] D69048: [LNT] Python 3 support: run tests with UTF-8 encoding

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D69048#1711272 <https://reviews.llvm.org/D69048#1711272>, @hubert.reinterpretcast wrote:

> I don't think that this is a clear "win". Users may have UTF-8 capable locales not ending in ".UTF-8" and also not have a usable `en_US.UTF-8` locale. It might be nice for some people, but this can actually break others. I don't see an issue with asking users to specify an appropriate value of `LANG` for their environment.


I can't quite remember but I think the problem is that lit starts from a clean environment to have consistent output (if using the user's environment error message might vary accross systems which would fail lots of tests). AFAIK LNT doesn't have localized error message but it fails to run if the locale is not UTF-8 (or perhaps any unicode locale).

[Sorry for the late answer, I missed that feedback.]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69048/new/

https://reviews.llvm.org/D69048