[PATCH] D70962: [LLD][ELF] .note.gnu.property sections should have wordsize alignment

Wed Dec 4 00:35:37 PST 2019

grimar accepted this revision.
grimar added a comment.

LGTM.

================
Comment at: lld/test/ELF/gnu-property-align.s:34
+
+.long 0xc0000002 # GNU_PROPERTY_X86_FEATURE_1_AND
+.long 4
----------------
MaskRay wrote:
> MaskRay wrote:
> > There is no `GNU_PROPERTY_X86_FEATURE_1_AND`...
> > 
> > @grimar I don't mind keeping this as `REQUIRES: aarch64`. I think an aarch64 test for 64-bit and an x86 test for 32-bit should be sufficient.
> Sorry, GNU_PROPERTY_X86_FEATURE_1_AND exists. This looks fine.
> I think an aarch64 test for 64-bit and an x86 test for 32-bit should be sufficient.

One of the reasons to use x86 for testing generic features is build bots. x86 is the most popular target,
which is enabled everywhere (or almost everywhere). x86 BB are also faster than others, in case of the breakage
they usually report the issue first.

It is also hard to imagine that for local development x86 target is disabled. Most of LLD tests rely on x86.
While aarch64 can be off.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70962/new/

https://reviews.llvm.org/D70962