[PATCH] D70665: [llvm-readobj] - Implement --dependent-lib-directives flag.

[George Rimar via Phabricator via llvm-commits]

grimar marked 3 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-readobj.rst:157
+
+ Display the dependent libraries section.
+
----------------
MaskRay wrote:
> jhenderson wrote:
> > section -> directives (in case it starts getting used by COFF)
> @bd1976llvm @jhenderson Do we have to call it `-directives`? A `#pragma` is referred to as a directive, but the section is not.
> 
> We support other options that dump extension sections (e.g. `--stack-sizes`). None has the suffix `-directives`. I think `--dependent-libs` (I presume you will prefer the plural form) should be fine.
> section -> directives (in case it starts getting used by COFF)

The section type is called "SHT_LLVM_DEPENDENT_LIBRARIES". That is why I haven't changed the description.
Given this the description seems to be fine?


================
Comment at: llvm/test/tools/llvm-readobj/elf-dependent-libraries.test:74
+
+# READELF: printELFDependentLibs not implemented!
----------------
jhenderson wrote:
> This test will fail right?
Oops. I guess this my last minute change wasn't included into the diff. I definitely fixed this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70665/new/

https://reviews.llvm.org/D70665