[PATCH] D70990: [dsymutil] Remove penultimate recursive call in lookForChildDIEsToKeep (NFC)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:794
+// completeness of one of its children. It depends on the incompleteness of the
+// children already being computed.
+static void updateChildIncompleteness(const DWARFDie &Die, CompileUnit &CU,
----------------
///


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:814
+// completeness of the DIEs referencing it. It depends on the incompleteness of
+// the referencing DIE already being computed.
+static void updateRefIncompleteness(const DWARFDie &Die, CompileUnit &CU,
----------------
///


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:821
+      Die.getTag() != dwarf::DW_TAG_ptr_to_member_type &&
+      Die.getTag() != dwarf::DW_TAG_pointer_type)
+    return;
----------------
switch?


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:829
+  if (MyInfo.Incomplete)
+    return;
+
----------------
these two lines are redundant. Are they useful for readability?


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:901
+    case WorklistItemType::LookForDIEsToKeep:
+      break;
     }
----------------
It's confusing that this break refers to a different block than the continue above :-)
no need to change anything


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:964
+    // Mark all DIEs referenced through attributes as kept.
+    std::vector<std::pair<DWARFDie, CompileUnit&>> ReferencedDIEs;
+    for (const auto &AttrSpec : Abbrev->attributes()) {
----------------
SmallVector now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70990/new/

https://reviews.llvm.org/D70990