[PATCH] D70982: [Gold] Add missing target flag to X86 Gold test

Troy Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 13:40:06 PST 2019


troyj created this revision.
troyj added a reviewer: tejohnson.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This test was failing on non-X86 targets because the gold invocation did not have the necessary -m flag.


https://reviews.llvm.org/D70982

Files:
  llvm/test/tools/gold/X86/linkonce_odr_unnamed_addr.ll


Index: llvm/test/tools/gold/X86/linkonce_odr_unnamed_addr.ll
===================================================================
--- llvm/test/tools/gold/X86/linkonce_odr_unnamed_addr.ll
+++ llvm/test/tools/gold/X86/linkonce_odr_unnamed_addr.ll
@@ -4,6 +4,7 @@
 ; RUN: opt -module-summary %s -o %t.o
 ; RUN: opt -module-summary %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2.o
 ; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
+; RUN:    -m elf_x86_64 \
 ; RUN:    --plugin-opt=save-temps \
 ; RUN:    %t.o %t2.o -o %t3.o
 ; RUN: llvm-dis %t.o.1.promote.bc -o - | FileCheck %s
@@ -12,6 +13,7 @@
 ; conservative and not auto hide.
 ; RUN: llc %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2native.o -filetype=obj
 ; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
+; RUN:    -m elf_x86_64 \
 ; RUN:    --plugin-opt=save-temps \
 ; RUN:    %t.o %t2native.o -o %t3.o
 ; RUN: llvm-dis %t.o.1.promote.bc -o - | FileCheck %s --check-prefix=NOSUMMARY


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70982.231979.patch
Type: text/x-patch
Size: 952 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191203/7c7f91c5/attachment.bin>


More information about the llvm-commits mailing list