[PATCH] D70867: [FPEnv] [PowerPC] Alternative lowering ppc_fp128 StrictFP Nodes to libcalls

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 12:06:46 PST 2019


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

Except for what appears to be a typo below, this LGTM.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7332
+    assert(VTList.VTs[0].isVector() == Ops[1].getValueType().isVector() &&
+           "STRICT_FP_EXTEND result type type should be vector iff the operand "
+           "type is vector!");
----------------
"type type"?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7344
+    assert(VTList.VTs[0].isVector() == Ops[1].getValueType().isVector() &&
+           "STRICT_FP_ROUND result type type should be vector iff the operand "
+           "type is vector!");
----------------
Again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70867/new/

https://reviews.llvm.org/D70867





More information about the llvm-commits mailing list