[PATCH] D70962: [LLD][ELF] .note.gnu.property sections should have wordsize alignment

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 10:24:16 PST 2019


MaskRay added inline comments.


================
Comment at: lld/test/ELF/gnu-property-align.s:34
+
+.long 0xc0000002 # GNU_PROPERTY_X86_FEATURE_1_AND
+.long 4
----------------
There is no `GNU_PROPERTY_X86_FEATURE_1_AND`...

@grimar I don't mind keeping this as `REQUIRES: aarch64`. I think an aarch64 test for 64-bit and an x86 test for 32-bit should be sufficient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70962/new/

https://reviews.llvm.org/D70962





More information about the llvm-commits mailing list