[PATCH] D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 09:00:05 PST 2019


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.
One nit below.



================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:772
+    if (MODef.getReg() != Src)
+      continue;
+
----------------
Should this be an assert?

Put differently, when can we find a backward copy for MODef.getReg() when the source is not MODef.getReg()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67794/new/

https://reviews.llvm.org/D67794





More information about the llvm-commits mailing list