[PATCH] D70447: [Support] ThreadPoolExecutor fixes for Windows/MinGW

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 08:23:19 PST 2019


andrewng added a comment.

I have also tested this patch with LLD built with libc++ on Ubuntu 18.04.3 LTS.

Does anyone have any comments on the actual patch itself?

I think it's beyond the scope of this patch to resolve the issues regarding the existence of both `Parallel.cpp` and `ThreadPool.cpp`. I agree with @ruiu that they serve different purposes and although some functionality could be shared/merged, I'm not entirely sure it would be worthwhile. Until we get to C++17, we're kind of stuck with `Parallel.cpp` for now...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70447/new/

https://reviews.llvm.org/D70447





More information about the llvm-commits mailing list