[PATCH] D70928: [PowerPC][NFC] Rename ANDI(S)o8 to ANDI(S)8o

[Jinsong Ji via Phabricator via llvm-commits]

jsji marked an inline comment as done.
jsji added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/P9InstrResources.td:134
+    (instregex "ANDI(S)?(8)?(o)?$"),
     (instregex "ADDC(8)?(O)?$"),
     (instregex "ADDIC(8)?(o)?$"),
----------------
jsji wrote:
> jhibbits wrote:
> > It looks to me like we need another change for P9InstrResources.td (not entirely related to this one), to fix some of these regex's to add the '(o)' suffix as well (ADDC, SUBF, SUBFC appear to need that)
> SUBF is just defined below im line 138.
> 
> ADDC/SUBBFC are defined later in around line 1035, as they are cracked.
> 
> ```
> 1035 // Cracked ALU operations.
> 1036 // Here the two ALU ops can actually be done in parallel and therefore the
> 1037 // latencies are not added together. Otherwise this is like having two
> 1038 // instructions running together on two pipelines and 2 dispatches. ALU ops are
> 1039 // 2 cycles each.
> 1040 def : InstRW<[P9_ALU_2C, P9_ALU_2C, IP_EXEC_1C, IP_EXEC_1C,
> 1041               DISP_1C, DISP_1C],
> 1042       (instrs
> 1043     (instregex "ADDC(8)?(O)?r$"),
> 1044     (instregex "SUBFC(8)?(O)?r$")
> 1045 )>;
> ```
Oops, `r` above in line 1043/1044 should be `o`. Sorry, I copied wrongly from my working branch where I have done renaming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70928/new/

https://reviews.llvm.org/D70928