[PATCH] D70961: [LLD][ELF] add support for PT_GNU_PROPERTY

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

The logic fine to me. A few comments/suggestions are inlined.



================
Comment at: lld/test/ELF/aarch64-pt-gnu-property.s:1
+# REQUIRES: aarch64
+# RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %s -o %t.o
----------------
I think you can use x86 for this test.


================
Comment at: lld/test/ELF/aarch64-pt-gnu-property.s:6
+
+# Test that we generate the PT_GNU_PROPERTY section that describes the
+# .note.gnu.property if it is present.
----------------
I think in LLD we also using `##` instead of `#` for comments nowadays.


================
Comment at: lld/test/ELF/aarch64-pt-gnu-property.s:30
+# CHECK-NEXT:     ]
+# CHECK-NEXT:     Alignment: 4
+
----------------
Please remove the excessive identation.


================
Comment at: lld/test/ELF/aarch64-pt-gnu-property.s:38
+
+.long 0xc0000000 // GNU_PROPERTY_AARCH64_FEATURE_1_AND
+.long 4
----------------
I'd suggest to be consistent and use "##" for comments too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70961/new/

https://reviews.llvm.org/D70961