[PATCH] D70894: [asan] Remove debug locations from alloca prologue instrumentation

Mon Dec 2 15:30:34 PST 2019

vsk added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2999
   IRBuilder<> IRB(InsBefore);
-  IRB.SetCurrentDebugLocation(EntryDebugLocation);

   // Make sure non-instrumented allocas stay in the entry block. Otherwise,
----------------
eugenis wrote:
> aprantl wrote:
> > Can there be calls anywhere in the prologue? If yes, this may cause a verifier error i any of these calls get inlined. What does the commit message for the deleted statements say?
> Yes, but they can not be inlined.
> 
Yeah, so long as these callees have no DISubprogram (and I don't see why they would) there should be no verifier issues.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70894/new/

https://reviews.llvm.org/D70894