[PATCH] D70929: Don't extract code containing an indirect jump from a callbr

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 15:21:21 PST 2019


vsk added a comment.

Could you add a test?



================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:135
+  // extracting an EH block.
+  for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE; ++PI)
+    if (isa<CallBrInst>(PI->getTerminator()))
----------------
nit: `const BasicBlock &PredBB : predecessors(BB)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70929/new/

https://reviews.llvm.org/D70929





More information about the llvm-commits mailing list