[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use r suffix instead of o

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 14:07:33 PST 2019


jsji added a comment.

> Furthermore, the flag we set in the multiclasses is called `isDOT` and there is no clear relationship between this "dot" and the letter `r`. All that said, I will not block this if the majority is in agreement (or indifferent). But let's get some more eyes on this.

Thanks for the review.  Yes, welcome others' input and comments.
To me `isDOT`  is saying the mne will have dot '.' at the end , that is exactly what the ISA says about mne of record form. And we can also rename `isDOT` to `isRecord` if we do need it to be explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758





More information about the llvm-commits mailing list